fix(linux): deadlock in WebViewUriLoader#1561
Merged
lucasfernog merged 3 commits intoAug 16, 2025
Merged
Conversation
A deadlock could occur, when a WebView was destroyed before handling `LoadEvent::Finished`. Refs tauri-apps/tauri#12589
Contributor
Package Changes Through c33b46cThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a deadlock, which could occur on Linux, when a WebView was destroyed before handling
LoadEvent::Finished. As a consequence, no further requests could be performed.With this fix, tauri-apps/tauri#12589 is no longer consistently reproducible. But there still seem to be rare situations, in which a deadlock could occur, so I don't think the issue can be closed.
Note: This PR could be slightly improved by disconnecting the
connect_destroysignal handler whenLoadEvent::Finishedis handled. But I'm not experienced in Rust development at all and have no idea how to move theSignalHandlerIdinto the closure to callwebview.disconnect(id).Additional context / long-term solution
The deadlock is caused by a workaround for a supposed bug in WebKitGTK. But the workaround introduces new bugs and negatively impacts request performance by queuing them up. Ideally, the underlying issue would be further investigated, so the workaround could be removed in the future. Currently, there doesn't seem to be an issue to track this problem and the bug has not been reported to the WebKitGTK project. As a start, it would be helpful to allow disabling the workaround. This way, it would be possible to verify if it is still needed for the latest WebKitGTK version.
Refs #359